added button to show all categories in the user's collection #9
Conversation
There was a problem hiding this comment.
Hey thanks for doing these, this looks great!
I do have a couple requests:
- Could you please change the "show more" button text to "Show Less" or "Hide Extra" or something on
!showAllvalues? - I think it would look a little cleaner to append the extra categories to the existing keyword results table? I'll attach a screenshot to show what it might look like.
- run
ng build --prodin the /snippets/ folder after you're done so that the changes will be compiled into the final application.
Let me know if that makes sense. Thanks so much for your help!
|
Appending extra categories to the table could look like this: |
|
Yes that makes perfect sense, thank you for letting me know. I will get to work on these changes. |
|
I'm a little new to pull requests and proper use of them. Would you like me to close this pull request and open another when I have completed the changes or is there a way to add commits to a pull request? Thanks for your help in this too. |
|
Since you're merging your master branch https://github.com/treventrujillo/cover-letter-snippets, you just make your commits the way you've already been doing it and I should be able to see the updates here I think. Let me know when you're done, thanks! |
|
I added the requested changes and built it up with ng build --prod. |
|
Issues #2 fixed. |
added button to show all categories in the user's collection. Fixing issue mattcheah#2
Added table under results table to show all unlisted categories. Modified pipe to return unlisted categories if passed argument.